Better integration with upcoming GitHub Actions extension #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
commented
Feb 27, 2022
| """Opportunistically add CirrusCI config if no other CI service was added.""" | ||
|
|
||
| uses_github_actions = struct.get(".github", {}).get("workflows") is not None | ||
| other_ci_files = [".gitlab-ci.yml"] |
There was a problem hiding this comment.
This is a bit add-hoc, although completely fine if we just want to consider extensions that we have completely control over (no 3rd-party).
Pull Request Test Coverage Report for Build 5313065817210880
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pyscaffold/pyscaffold#619 we are proposing a new
--github-actionsextension to PyScaffold that will add a workflow that already contains the publish action1.Ideally we want to avoid
--github-actionsand--custom-extensionto created repeated CI actions.Moreover, if the user wants to use
--github-actionsor--gitlab(or--bitbucket-ci, etc), it is highly unlikely that--cirrusshould automatically be added to the mix.In this PR, I attempt to postpone the automatic inclusion of
--cirrus, and prevent it from happening entirely if--github-actionsor--gitlabhave been explicitly passed.Footnotes
The reason why the same workflow file contains both the tests and the publish job is because GitHub currently has no easy way of expressing dependencies between different workflows. This way unless everything is in the same file there is no way of preventing a release to proceed when the tests fail. ↩