Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit COVERALLS_REPO_TOKEN #479

Merged
merged 1 commit into from Jul 30, 2021
Merged

Remove explicit COVERALLS_REPO_TOKEN #479

merged 1 commit into from Jul 30, 2021

Conversation

abravalheri
Copy link
Collaborator

@abravalheri abravalheri commented Jul 29, 2021

… rely, instead, on environment variable overwritten by Cirrus GUI

This should fix issue #449.
As discussed in the issue, the idea is to use the GUI to provide the env var, which should be readable by all contributors

… rely, instead, on environment variable overwritten by Cirrus GUI
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4989627141455872

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.281%

Totals Coverage Status
Change from base Build 6395326266343424: 0.0%
Covered Lines: 1630
Relevant Lines: 1662

💛 - Coveralls

@abravalheri abravalheri marked this pull request as ready for review July 29, 2021 16:33
@abravalheri
Copy link
Collaborator Author

The approach discussed in #449 seems to work... 🤞
We are only going to know when a new PR from other contributors arrive...

@FlorianWilhelm
Copy link
Member

Cool, thanks. LGTM :-)

@abravalheri abravalheri merged commit 2333394 into master Jul 30, 2021
@abravalheri abravalheri deleted the issue-449 branch July 30, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants