Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Tensor._sample to handle dice_factor as Delta's log_density #569

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ordabayevy
Copy link
Member

@ordabayevy ordabayevy commented Oct 7, 2021

Similar to #551 this rewrites Tensor._sample to place dice_factor into Delta(name, point, dice_factor). In doing so I found it easier:

  • to do shape manipulations in funsor as much as possible
  • to sample one variable at a time instead of all variables in the single call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant