Update dependencies #61
Conversation
studioromeo
force-pushed
the
update-dependencies
branch
from
661981e
to
af8008b
Compare
studioromeo
force-pushed
the
update-dependencies
branch
from
af8008b
to
0dd2371
Compare
This is so we can have a minimum support of PHP 7.1
studioromeo
force-pushed
the
update-dependencies
branch
from
a0bd0af
to
704c48b
Compare
|
Heya. Sorry to bump this but I'm wondering as it's been a while if you've had any thoughts on this PR? I noticed #66 has been raised since I raised this one so I've adjusted this PR to meet the discussions being held in that one. Thanks |
|
Hello @studioromeo. Sorry I completely forgot your PR 馃槙 Thanks a lot for it! I just merged #66 so could please rebase your branch on top of master and resolve the conflict? 馃檹 Thanks |
| @@ -98,8 +99,6 @@ public function test_it_is_registered_and_activated() | |||
| $this->addComposerPlugin($plugin); | |||
|
|
|||
| $this->assertSame([$plugin], $this->composer->getPluginManager()->getPlugins()); | |||
| $this->assertAttributeInstanceOf('Composer\IO\IOInterface', 'io', $plugin); | |||
| $this->assertAttributeInstanceOf('Pyrech\ComposerChangelogs\Outputter', 'outputter', $plugin); | |||
There was a problem hiding this comment.
Why did these 2 asserts disappeared?
There was a problem hiding this comment.
Ah we may be able to add them back in again but essentially in PHPUnit 8.x assertAttributeInstanceOf is deprecated. Apparently the author felt that allowing tests that check the attribute value is bad practice and so removed them sebastianbergmann/phpunit#3339
I figured here theres little to be gained by adding getters for io & outputter but can do that if you like?
There was a problem hiding this comment.
I think I added those asserts to ensure the plugin is always activated correctly (as some of its dependencies depends from Composer) : https://github.com/pyrech/composer-changelogs/blob/master/src/ChangelogsPlugin.php#L59
But anyway, we can probably drop them 馃槈
|
Sorry @studioromeo for not taking enough time to address your comment and merge your PR. In the meantime, #68 was just merged so I guess we can now close this PR. Again sorry and do not hesitate to reopen if you think we missed something. |
Hey 馃憢
I've updated the dependencies to their latest available versions.
Theres two main bumps here:
I've tried to port as much of the cs fixer config over but I noticed that it's reordered the comparison operators in some places. I hope this is ok but let me know if you'd like anything changed.