Equilateral Triangle ROI #1581
Merged
Equilateral Triangle ROI #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added equilateral TriangleROI. getArrayRegion is not working yet
refactor the actual logic to live on ROI
* variable names * lint * docstring type and purpose
outofculture
force-pushed
the
triangle-roi
branch
from
ad956f8
to
8d5d7aa
Compare
Closed
|
The failing checks look to be unrelated. Docs build fails in the same way on master. The windows+pyside+3.7 failure is intermittent on all branches. |
|
I feel vaguely uneasy about merging my own PR, but this is really just the continuation of #664. This is mostly a new feature, with one refactor to support it, so the surface area of possible risk to others' code is very small. The failing build also gives me pause, but all the tests pertaining to this code have passed. |
|
docs build error is here: sphinx-doc/sphinx#8880 It's been fixed and will be part of the sphinx 3.5.1 release. Thanks for the PR/merge @outofculture and thanks for the originally submission @feketeimre sorry we didn't follow up earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and implemented all the changes I requested on #664