Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use simple interactive console if stdin is closed (issue 2981) #4947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

obafgkmdh
Copy link

This fixes #2981.

@cfbolz
Copy link
Member

cfbolz commented May 11, 2024

OK, looks reasonable. Can we write a unit test for this behavior somehow?

@mattip
Copy link
Member

mattip commented May 11, 2024

It seems CPython forked and created its own version of pyrepl, this was tracked in cpython issue python/cpython#111201. It would be good to try to see what the diff is to that code, and update PyPy to match or at least document the differences.

@mattip
Copy link
Member

mattip commented May 11, 2024

I wonder if there is some overlap between our pyrepl issues and the ones in cpython https://github.com/python/cpython/labels/topic-repl

@cfbolz
Copy link
Member

cfbolz commented May 13, 2024

@mattip yes, I'm following the CPython topic. About half the fixes are for issues in the new features that cpy added, and some are for pyrepl issues.

My strategy would be to wait a few weeks for them to stabilize things and then start to backport fixes (and maybe some of the new features).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

script exited with exit break from pypy interactive mode
3 participants