Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "make test_transformed_gc tests more stable" #4870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

olliemath
Copy link
Contributor

Reverts #4868

This didn't seem to work - so something else must be at play here

@mattip
Copy link
Member

mattip commented Jan 17, 2024

Let's let this change run by the rpython nightly buildbot build, perhaps it will give us more data.

@mattip
Copy link
Member

mattip commented Jan 18, 2024

That specific test test_transformed_gc does not show up at all in the buildbot runs, neither before or after #4868. Some of the buildbots (macos-arm64 macos-x86_64, windows) use pypy2 as a test runner host python, and last night's run cleared up some other failures on macos-arm64 test.test_boehm, so maybe you are on to something? Are there other places that also need to call the GC to clear caches?

@mattip
Copy link
Member

mattip commented Jan 18, 2024

Here is the link to the rpython builbot runs, it also appears on the top navbar of the buildbot pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants