RPYTHON: embed rpython code line as a comment in the generated C #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
commented
Jan 7, 2024
| code = self.pycode | ||
| linenum = self.last_offset | ||
| src = self.graph.source.split('\n')[linenum] | ||
| text = '%s:%d : %s' % (code.co_name, linenum, src) |
There was a problem hiding this comment.
This part fails. self.pycode is the compiled bytecode, and the last_offset relates to a bytecode offset, not a code linenum. Do we have any information about the line number in the source code anywhere?
There was a problem hiding this comment.
yes, you can call offset2lineno(code, self.last_offset) to get the line number. the function is in rpython.tool.error.
mattip
commented
Jan 7, 2024
Comment on lines
+401
to
+404
| except Exception as e: | ||
| print(e) | ||
| import pdb;pdb.set_trace() | ||
| raise |
There was a problem hiding this comment.
Remove this when the comment creation works
Suggested change
| except Exception as e: | |
| print(e) | |
| import pdb;pdb.set_trace() | |
| raise |
|
cool! pitfalls that I can think off:
you should probably add some unit tests to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a patch to #1220. I am trying to update it.