(Do not merge yet) Add simple float.max specialization #4811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know a place to put this
Not sure how to run it yet, though
Figure out how to run the runner tests (they are parameterized): ./pytest.py -vv rpython/jit/backend/x86/test/test_runner.py
Turns out I was accidentally passing in the address of the function instead of the args.
|
In GitLab by @tekknolagi on Sep 28, 2023, 19:06 requested review from @cfbolz |
|
In GitLab by @tekknolagi on Sep 28, 2023, 19:07 I want to add some test for disassembly |
|
In GitLab by @tekknolagi on Sep 28, 2023, 19:15 added 1 commit
|
|
In GitLab by @tekknolagi on Sep 28, 2023, 19:19 added 1 commit
|
|
In GitLab by @tekknolagi on Sep 28, 2023, 19:28 added 1 commit
|
|
In GitLab by @tekknolagi on Oct 2, 2023, 04:05 added 9 commits
|
devdanzin
reviewed
May 22, 2024
| return max(a, b) | ||
| res = self.interp_operations(f, [-5.25, 3]) | ||
| assert res == 3 | ||
| # TODO(emacs): Figure out why nan causes issues here |
There was a problem hiding this comment.
Would it be because "If only one value is a NaN (SNaN or QNaN) for this instruction, the second source operand, either a NaN or a valid floating-point value, is written to the result"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GitLab by @tekknolagi on Sep 28, 2023, 19:06
--HG--
branch : mb-dup