BUG: Ensure numpy masked arrays stay masked after projection #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1103 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 20 20
Lines 1794 1794
=======================================
Hits 1725 1725
Misses 69 69
Continue to review full report at Codecov.
|
snowman2
reviewed
Jul 10, 2022
As noted in pyproj4#1102, projecting numpy masked arrays returned numpy masked arrays in the 2.x series of pyproj. This behaviour changed in commit 4ab3ff7 as part of the 3.x series, where a "plain" numpy ndarray was returned. The change implemented here ensures that projecting numpy masked arrays returns masked arrays as was previously the case.
paultcochrane
force-pushed
the
1102-keep-numpy-masked-arrays-masked
branch
from
b3a47ca
to
0808144
Compare
snowman2
changed the title
|
Thanks @paultcochrane 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1102, projecting numpy masked arrays returned numpy masked
arrays in the 2.x series of pyproj. This behaviour changed in commit
4ab3ff7 as part of the 3.x series, where a "plain" numpy ndarray was returned. The change
implemented here ensures that projecting numpy masked arrays returns
masked arrays as was previously the case.
I'm fairly sure that the fix I've implemented here does actually fix the issue mentioned in #1102; nevertheless, please review my changes carefully as I'm not very familiar with this codebase.
history.rstfor all changes andapi/*.rstfor new API