fix: add hostname to URLs generated in email #15960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keep in mind: We're in code freeze for now, so unless this is urgent, we may not merge it until we're out of code freeze. |
woodruffw
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM behaviorally -- thanks for catching this @miketheman!
(IMO this is not extremely urgent, so it can wait until after the freeze.)
Since this email is triggered during upload, the resulting domain sent to users is broken, as it's using `uploads.pypi.org` which this domain doesn't support. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/fix-url
branch
from
4d69239
to
8dcbcc2
Compare
ewdurbin
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this email is triggered during upload, the resulting domain sent
to users is broken, as it's using
uploads.pypi.orgwhich this domaindoesn't support.
Signed-off-by: Mike Fiedler miketheman@gmail.com