Add base_publisher_url to file/release events.
#15872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanlacerda
approved these changes
Apr 26, 2024
| ) | ||
| DBFileEventFactory.create( | ||
| source=release_file, | ||
| tag="fake:event", | ||
| additional={"publisher_url": publisher_url}, | ||
| additional={"base_publisher_url": base_publisher_url}, |
There was a problem hiding this comment.
Why do we need this second event?
There was a problem hiding this comment.
To catch the bug that this commit fixed: 7f93c42. It was failing because it doesn't work when there are multiple events found.
There was a problem hiding this comment.
I see!! Awesome! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with #15862, where the
publisher_urlfor most events contained a commit SHA, and therefore had additional parts that made it hard to compare with project URLs.The workaround is to introduce a
base_publisher_urladditional field that represents the unique "root" of the publisher for all publishers (i.e. the github repo) which we can use to compare to project URLs to verify them.This means that these links will become verified only once a new event is published with this additional field, which should slowly happen over time.
To speed this up, we could do a one-off data migration to add
base_publisher_urlto existing events, but I think this should be fine as-is.