Render missing security history events #15702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzohrab
commented
Apr 2, 2024
jzohrab
commented
Apr 2, 2024
| @@ -504,6 +504,20 @@ <h2>{% trans %}API tokens{% endtrans %}</h2> | |||
| <section id="account-events"> | |||
| <h2>{% trans %}Security history{% endtrans %}</h2> | |||
|
|
|||
| {% set role_strings = { | |||
There was a problem hiding this comment.
I think this method is clean but it deviates from existing code, LMK if you don't like it.
di
reviewed
Apr 2, 2024
|
Thanks @di for the comment. I've completed this, I think, and removed all of the cruft comments from the PR, and rebased off main. CI now passes. |
jzohrab
force-pushed
the
issue_13934_render_missing_security_history_events
branch
from
5abe94d
to
55617c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13934
I've added what I felt was the relevant detail for each event.