Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests, warehouse: disable egg uploads #14118

Merged
merged 6 commits into from
Aug 1, 2023
Merged

tests, warehouse: disable egg uploads #14118

merged 6 commits into from
Aug 1, 2023

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jul 13, 2023 •
edited

DO NOT MERGE UNTIL AUGUST 1

Also removes the PEP 715 notice emails, since they'll cease to serve any purpose once eggs can't be uploaded.

Closes #10653.

@woodruffw
tests, warehouse: disable egg uploads
6581c04 
Also removes the PEP 715 notice emails, since they'll cease to
serve any purpose once eggs can't be uploaded.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested a review from a team as a code owner July 13, 2023 16:15
@woodruffw woodruffw self-assigned this Jul 13, 2023
@woodruffw woodruffw added the blocked Issues we can't or shouldn't get to yet label Jul 13, 2023
@woodruffw woodruffw mentioned this pull request Jul 13, 2023
Closed
@woodruffw
tests: lintage
bc19dfe 
Signed-off-by: William Woodruff <william@trailofbits.com>
@di
Copy link
Member

di commented Jul 13, 2023

I wonder if we want to provide a specific error message when someone tries to upload an egg indicating that it's deprecated rather than just an invalid file? I think it's probably likely we haven't actually been able to inform everyone that might try to upload an .egg in the future.

@woodruffw
Copy link
Member Author

@di Were you thinking something beyond this?

https://github.com/pypi/warehouse/pull/14118/files#diff-bffd49e4f943217b54b4cfcf5835737bec7a145360bd1dc2ec1541d2dcafad16L663-R664

That updates the message to include the new PEP as well, but the "Invalid file extension" summary goes to your point about potentially confusing users. I could probably tweak or specialize that error case to emphasize that the error is due to a deprecation, and not an invalid file per se.

@di
Copy link
Member

di commented Jul 14, 2023

@woodruffw Ah, I missed that change. I suppose that should be sufficient!

@woodruffw woodruffw changed the title [DNM] tests, warehouse: disable egg uploads tests, warehouse: disable egg uploads Jul 31, 2023
@woodruffw
Copy link
Member Author

This is updated and good to go by tomorrow!

di
di approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐣

@miketheman
Copy link
Member

Related: pypa/packaging.python.org#1278

@miketheman miketheman removed the blocked Issues we can't or shouldn't get to yet label Aug 1, 2023
@woodruffw
Copy link
Member Author

🍳

@di di enabled auto-merge (squash) August 1, 2023 14:21
@di di merged commit 8643ade into pypi:main Aug 1, 2023
15 of 17 checks passed
@woodruffw woodruffw deleted the tob-de-egg-warehouse branch August 1, 2023 14:25
@di di mentioned this pull request Aug 1, 2023
Merged
@hugovk hugovk mentioned this pull request Aug 24, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees

@woodruffw woodruffw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate .egg uploads
3 participants
@woodruffw @di @miketheman