Skip to content

Commit

Permalink
Remove type exclusions and test for third party types. (#11571)
Browse files Browse the repository at this point in the history
* chore(deps): add `types-babel` package for mypy

`types-babel` is part of the typeshed, and has been released since 2021.
I must have missed it when doing the initial types pass.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* chore(deps): add `msgpack-types` for mypy

Refs: https://github.com/sbdchd/msgpack-types

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* chore(deps): add `types-passlib` for mypy

`types-passlib` was added to the typeshed after inital mypy work was
done, so we can now remove our exclusion.

Refs: python/typeshed#7024
(initial commit, others have followed)

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* chore(deps): add `types-stdlib` for mypy

Types have been added to typeshed

Refs: python/typeshed#7608

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* lint: remove excluded `trove_classifiers`

Type hints added in pypa/trove-classifiers#96
warehouse updated in #11167

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* chore(deps): add `types-sqlalchemy-utils` for mypy

Package added in April, after initial typing was introduced.

Refs: https://github.com/cex-solutions/types-sqlalchemy-utils/releases/tag/v1.0.0

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

* docs: add more links to open types requests

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
  • Loading branch information
miketheman committed Jun 15, 2022
1 parent 2dc7fce commit 768d5e2
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 10 deletions.
10 changes: 2 additions & 8 deletions pyproject.toml
Expand Up @@ -19,8 +19,7 @@ exclude = ["warehouse/locale/.*", "warehouse/migrations/versions.*"]
# These modules do not yet have types available.
module = [
"automat.*",
"babel.*",
"bpython.*",
"bpython.*", # https://github.com/bpython/bpython/issues/892
"celery.app.backends.*",
"celery.backends.redis.*",
"citext.*",
Expand All @@ -29,10 +28,8 @@ module = [
"google.cloud.*",
"IPython.*",
"mistune.*",
"msgpack.*",
"paginate.*",
"paginate_sqlalchemy.*",
"passlib.*",
"premailer.*",
"pymacaroons.*", # https://github.com/ecordell/pymacaroons/issues/41
"pyramid.*", # https://github.com/Pylons/pyramid/issues/2638
Expand All @@ -41,13 +38,10 @@ module = [
"pyramid_retry.*",
"pyramid_rpc.*",
"pyqrcode.*",
"requests_aws4auth.*",
"requests_aws4auth.*", # https://github.com/tedder/requests-aws4auth/issues/53
"rfc3986.*",
"stdlib_list.*",
"sqlalchemy.*", # https://docs.sqlalchemy.org/en/14/orm/extensions/mypy.html
"sqlalchemy_utils.*",
"transaction.*",
"trove_classifiers.*",
"venusian.*",
"whitenoise.*",
"wtforms.*", # https://github.com/wtforms/wtforms/issues/618
Expand Down
5 changes: 5 additions & 0 deletions requirements/lint.in
Expand Up @@ -6,15 +6,20 @@ black==22.3.0
isort>=5
mypy
celery-types
msgpack-types
mypy-zope
types-babel
types-boto3
types-certifi
types-first
types-html5lib
types-itsdangerous
types-passlib
types-psycopg2
types-python-slugify
types-pytz
types-redis
types-requests
types-setuptools
types-sqlalchemy-utils
types-stdlib-list
26 changes: 24 additions & 2 deletions requirements/lint.txt
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with python 3.9
# This file is autogenerated by pip-compile with python 3.10
# To update, run:
#
# pip-compile --allow-unsafe --generate-hashes --output-file=requirements/lint.txt requirements/lint.in
Expand Down Expand Up @@ -79,6 +79,10 @@ mccabe==0.6.1 \
--hash=sha256:ab8a6258860da4b6677da4bd2fe5dc2c659cff31b3ee4f7f5d64e79735b80d42 \
--hash=sha256:dd8d182285a0fe56bace7f45b5e7d1a6ebcbf524e8f3bd87eb0f125271b8831f
# via flake8
msgpack-types==0.2.0 \
--hash=sha256:7e5bce9e3bba9fe08ed14005ad107aa44ea8d4b779ec28b8db880826d4c67303 \
--hash=sha256:b6b7ce9f52599f9dc3497006be8cf6bed7bd2c83fa48c4df43ac6958b97b0720
# via -r requirements/lint.in
mypy==0.961 \
--hash=sha256:006be38474216b833eca29ff6b73e143386f352e10e9c2fbe76aa8549e5554f5 \
--hash=sha256:03c6cc893e7563e7b2949b969e63f02c000b32502a1b4d1314cabe391aa87d66 \
Expand Down Expand Up @@ -167,6 +171,10 @@ tomli==2.0.1 \
# via
# black
# mypy
types-babel==2.9.12 \
--hash=sha256:0dc19c3d4a6546f1ff409db561edebba97e4a4ea6f95793895fa1ad89f34469b \
--hash=sha256:d43896f8bcbb3f026c4e2da891a817bcbf4a316f7bc1e86698c594a65917d928
# via -r requirements/lint.in
types-boto3==1.0.2 \
--hash=sha256:15f3ffad0314e40a0708fec25f94891414f93260202422bf8b19b6913853c983 \
--hash=sha256:a6a88e94d59d887839863a64095493956efc148e747206880a7eb47d90ae8398
Expand All @@ -187,6 +195,10 @@ types-itsdangerous==1.1.6 \
--hash=sha256:21c6966c10e353a5d35d36c82aaa2c5598d3bc32ddc8e0591276da5ad2e3c638 \
--hash=sha256:aef2535c2fa0527dcce244ece0792b20ec02ee46533800735275f82a45a0244d
# via -r requirements/lint.in
types-passlib==1.7.5 \
--hash=sha256:810ce820882a900429b2cbe6554851182370337c7246b0e0728ff4145db0edcf \
--hash=sha256:8366c5e31bbff65c0a6d1a0f10e84fba567797680c643b485b072691bc0908db
# via -r requirements/lint.in
types-psycopg2==2.9.16 \
--hash=sha256:adf3be817cb82e17e6d36c4112718dbda38f98db291d736f022a1d89b53c832c \
--hash=sha256:b350d7cf7aaa24c42854f6656fb70547799271eccb738fc5e244840b798bb373
Expand All @@ -198,7 +210,9 @@ types-python-slugify==5.0.4 \
types-pytz==2021.3.8 \
--hash=sha256:41253a3a2bf028b6a3f17b58749a692d955af0f74e975de94f6f4d2d3cd01dbd \
--hash=sha256:aef4a917ab28c585d3f474bfce4f4b44b91e95d9d47d4de29dd845e0db8e3910
# via -r requirements/lint.in
# via
# -r requirements/lint.in
# types-babel
types-redis==4.2.6 \
--hash=sha256:1136af954ade0be33b487f440c8cbcbee29f089a83e685484ec91f363c6c69fe \
--hash=sha256:d6adc77185cf40b300816767a64c0ee9ee0b21dc174e8e5c23b7e83d43189cb8
Expand All @@ -211,6 +225,14 @@ types-setuptools==57.4.17 \
--hash=sha256:9c7cdaf0d55113e24ac17103bde2d434472abf1dbf444238e989fe4e798ffa26 \
--hash=sha256:9d556fcaf6808a1cead4aaa41e5c07a61f0152a875811e1239738eba4e0b7b16
# via -r requirements/lint.in
types-sqlalchemy-utils==1.0.0 \
--hash=sha256:64403b5260fffcb0ee04fd37167f5c1d1cc68d103f82ef2d5d868e7ac281d5e5 \
--hash=sha256:a7dd1b85afeb914a47c8d1244d5614128559c58a1f057284071da2e2257d2424
# via -r requirements/lint.in
types-stdlib-list==0.8.0 \
--hash=sha256:ab12db739d59548c47f9d1acd0ee515ae66ac29d17e097481795eed3b9fa1462 \
--hash=sha256:bbe5f34503d8b7f6ec11d75ff0ee01ef1d719c81215fa43b334557a879270fdb
# via -r requirements/lint.in
types-urllib3==1.26.15 \
--hash=sha256:6011befa13f901fc934f59bb1fd6973be6f3acf4ebfce427593a27e7f492918f \
--hash=sha256:c89283541ef92e344b7f59f83ea9b5a295b16366ceee3f25ecfc5593c79f794e
Expand Down

0 comments on commit 768d5e2

Please sign in to comment.