Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid assigning an empty error message to delegated parse exception #534

Merged
merged 1 commit into from Feb 12, 2024
Merged

Avoid assigning an empty error message to delegated parse exception #534

merged 1 commit into from Feb 12, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Fixes #527.

@lemenkov
Copy link

Fixes #527 for me. Also fixes eerimoq/asn1tools#167.
Hope it will hit upstream shortly.

@lemenkov lemenkov mentioned this pull request Feb 10, 2024
Open
@ptmcg ptmcg self-requested a review February 12, 2024 11:20
ptmcg
ptmcg approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@ptmcg ptmcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good - I have written some unit tests that verify this does the right thing, I'll add them in after merging this.

@ptmcg ptmcg merged commit f02e401 into pyparsing:master Feb 12, 2024
9 checks passed
@InSyncWithFoo InSyncWithFoo deleted the 527 branch March 6, 2024 15:33
@ptmcg ptmcg mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptmcg ptmcg ptmcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom error messages inside Group
3 participants
@InSyncWithFoo @lemenkov @ptmcg