Whitespace changes for readability #523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you running black on these changes? I expected black to take care of whitespace mods. |
|
No, I haven't. Personally I have never used it since my code style (using many empty lines, as you can see) is quite different from PEP 8/black. I tried it just now and the result looks pretty much not my taste. Of course, you can choose whether to accept this PR or not. I don't recommend running black on this since that would just result in an ugly mix of both. |
|
Thanks for submitting, but when I run black, it will likely revert most of these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #519.
Hopefully I'll be working on core.py tomorrow or so.