Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow int or None for cache_size_limit to enable_packrat. #499

Merged
merged 1 commit into from Jul 28, 2023
Merged

Allow int or None for cache_size_limit to enable_packrat. #499

merged 1 commit into from Jul 28, 2023

Conversation

mikeurbach
Copy link
Contributor

This should close #498.

@ptmcg
Copy link
Member

ptmcg commented Jul 20, 2023

LGTM - will review again in my dev environment when I return from vacation.

@ptmcg ptmcg self-requested a review July 28, 2023 07:51
@ptmcg ptmcg merged commit a60ec32 into pyparsing:master Jul 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptmcg ptmcg ptmcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The enable_packrat type annotation prevents passing None for cache_size_limit
2 participants
@mikeurbach @ptmcg