optimize pyparsing import time by deferring regex compile #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thanks! |
|
|
||
| @cached_property | ||
| def re(self): | ||
| if self._re: |
There was a problem hiding this comment.
Wouldn't it be possible to always assign to re and thus remove the extra attribute for a given pattern
There was a problem hiding this comment.
@asottile my understanding is that a cached property can be assigned a value using the same attribute name, as its using the dict as cache
that way the assigment should suffice
There was a problem hiding this comment.
yes, but self._re is used separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #362
using the same script in that PR: