Add early break when checking warning inside a for loop

pyparsing · Mar 6, 2024 · 9533fcb · 9533fcb
1 parent d252980
commit 9533fcb
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/pyparsing/core.py b/pyparsing/core.py
@@ -3858,15 +3858,18 @@ def _setResultsName(self, name, listAllMatches=False):
             if (
                 isinstance(e, ParserElement)
                 and e.resultsName
-                and Diagnostics.warn_ungrouped_named_tokens_in_collection
-                not in e.suppress_warnings_
+                and (
+                    Diagnostics.warn_ungrouped_named_tokens_in_collection
+                    not in e.suppress_warnings_
+                )
             ):
                 warning = (
                     "warn_ungrouped_named_tokens_in_collection:"
                     f" setting results name {name!r} on {type(self).__name__} expression"
                     f" collides with {e.resultsName!r} on contained expression"
                 )
                 warnings.warn(warning, stacklevel=3)
+                break
 
         return super()._setResultsName(name, listAllMatches)
 
@@ -4962,15 +4965,18 @@ def _setResultsName(self, name, listAllMatches=False):
                 if (
                     isinstance(e, ParserElement)
                     and e.resultsName
-                    and Diagnostics.warn_ungrouped_named_tokens_in_collection
-                    not in e.suppress_warnings_
+                    and (
+                        Diagnostics.warn_ungrouped_named_tokens_in_collection
+                        not in e.suppress_warnings_
+                    )
                 ):
                     warning = (
                         "warn_ungrouped_named_tokens_in_collection:"
                         f" setting results name {name!r} on {type(self).__name__} expression"
                         f" collides with {e.resultsName!r} on contained expression"
                     )
                     warnings.warn(warning, stacklevel=3)
+                    break
 
         return super()._setResultsName(name, listAllMatches)