Allow bdist_wheel working without ctypes #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 13 13
Lines 1083 1083
=======================================
Hits 770 770
Misses 313 313 ☔ View full report in Codecov by Sentry. |
henryiii
reviewed
Apr 25, 2024
|
@henryiii Could you review it again? |
agronholm
reviewed
May 5, 2024
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
henryiii
reviewed
May 6, 2024
agronholm
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am a developer of RustPython project.
Currently RustPython barely can run pip, but installing projects usually fails due to lack of ctypes - which is mostly not mandatory.
This patch makes ctypes optional in most of platforms and situations.