Make wheelfile a stand-alone module to simplify vendoring #318
Conversation
The error is used when an error occurs anywhere in the wheel package. The core part of the package is the wheelfile module. Because its needed there, and to simplify vendoring of wheelfile let's move the definition to that file. This change won't affect behavior. Additionally, relative imports are used throughout the cli for consistency.
FRidh
force-pushed
the
vendor
branch
2 times, most recently
from
5cb1a8f
to
68858f5
Compare
The utils are only used by wheelfile and its not like its a lot of utility functions either that it warrants a module of its own. This simplifies vendoring of wheelfile.
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
==========================================
- Coverage 64.89% 64.82% -0.08%
==========================================
Files 13 12 -1
Lines 997 995 -2
==========================================
- Hits 647 645 -2
Misses 350 350
Continue to review full report at Codecov.
|
|
Do you have a specific project you want to vendor this module to? Also, wouldn't it be prudent to decide the public API first? |
I am experimenting currently with a PEP 517 back-end that could support multiple systems, such as meson, cmake and scons. So far I am fine using my fork, so no need to get it in.
Maybe. See it as a first step. At this point, it is not fixed yet. But this module ( |
|
Here are a couple of other wheel manifest generators to compare. https://bitbucket.org/dholth/sdl2_lib/src/66225dd8dc2d77ba21c6e7b1938b9a70116bb18e/wscript#lines-65 |
|
I will probably end up rejecting this due to the major refactoring I'm doing in the publicapi branch. |
|
Yeah, you will find that the new wheelfile module in the |
#262 proposes a public API for the wheel package. That's a good thing to reduce duplication and facilitate reuse. I would expect it to be primarily used by build systems such as setuptools, flit, enscons, mesonpep517, ...
However, bootstrapping of build systems that have external dependencies is often problematic (pypa/setuptools#980). The core of this package is the
wheelfilemodule. Let's make it so that others can easily vendor this now stand-alone module.