Fix extracted files permissions #609
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the extracted file permissions when using .extract/.extract_files in addition to when using the unpack cli command. The fix is by overriding the _extract_member method of zip file, and adding permissions fix there. The permissions fix was moved from the unpack to the new method.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 71.28% 71.41% +0.13%
==========================================
Files 13 13
Lines 1069 1074 +5
==========================================
+ Hits 762 767 +5
Misses 307 307 ☔ View full report in Codecov by Sentry. |
gilfree
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #608: This commit fixes the extracted file permissions when using .extract/.extract_files in addition
to when using the unpack cli command.
The fix is by overriding the _extract_member method of zip file, and adding permissions fix there.
The permissions fix was moved from the unpack to the new method.