-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executable permissions are lost when converting to wheel to conda package #135
Comments
Thanks for the report! Obviously, the lazy solution is to wait for this to get fixed in wheel, but I am open to a PR if you want to submit one. If you do, I think you should provide an |
I'm ok with waiting a few weeks to see what wheel's response will be. If they won't solve it, I'll try to find time to submit a PR. |
One workaround for this would be to convert the wheel to a directory tree instead of a V1 or V2 format package and then manually fix the permissions of the script files and then use e.g.
|
Seems wheel devs are responsive - pypa/wheel#609. |
I should update the wheel dependency when this fix is available... |
I must point out that |
I guess that technically it is dubious but in practice it is highly unlikely that code is actually going to change. The current API has been in place for 6 years already, Yes, I do believe that I could use |
Another issue with |
Another issue with file permissions is that is not really supported on Windows. On windows calling |
Thanks! |
Describe the bug
If a wheel file contains a file with executable permissions - they will be lost when converting to a conda package.
To Reproduce
Create a python package with a script that has executable permission (chmod +x) and convert to conda.
Expected behavior
The executable permissions should be kept.
The root cause of the bug is in here: pypa/wheel#608.
To fix it, until
wheel
is fixed _extract_wheel method need to be updated:To something along the lines of:
(Code taken from: https://github.com/pypa/wheel/blob/0a4f40ecf967757b43e2cdfd4b3c52b16d15614a/src/wheel/cli/unpack.py#L24)
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: