Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Requires-Dist format to not use parentheses #395

Closed
uranusjr opened this issue Feb 24, 2021 · 1 comment · Fixed by #614
Closed

Change Requires-Dist format to not use parentheses #395

uranusjr opened this issue Feb 24, 2021 · 1 comment · Fixed by #614

Comments

@uranusjr
Copy link
Member

According to the Requires-Dist section in the active Core Metadata specification:

A version specifier. Tools parsing the format should accept optional parentheses around this, but tools generating it should not use parentheses.

wheel currently generates the version with parentheses, which is acceptable but not recommended. The format triggers bugs in the parsing tool (pypa/packaging#336). It would be perfectly reasonable to not change this due to backwards compatibility, but I want to raise the possibility since the paranthesis requirement has been removed for quite a while and may no longer be relevant.

@wimglenn
Copy link
Contributor

wimglenn commented Apr 30, 2024

This issue is outdated - there are no longer superfluous parens around the version specifier (fixed by 2a0a487). However, there are still superfluous parens on conditions, probably due to some code around here.

wimglenn added a commit to wimglenn/wheel that referenced this issue Apr 30, 2024
This makes the METADATA file from bdist_wheel and the PKG-INFO file from setuptools render the same way (see pypa/setuptools#4336 for more info)

Closes pypa#395
agronholm pushed a commit that referenced this issue May 1, 2024
This makes the METADATA file from bdist_wheel and the PKG-INFO file from setuptools render the same way (see pypa/setuptools#4336 for more info).

Closes #395.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants