-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requires-Dist metadata not canonicalized between wheels and sdists #4336
Comments
pypa/wheel#395 similar issue on the wheel repo |
This makes the METADATA file from bdist_wheel and the PKG-INFO file from setuptools render the same way (see pypa/setuptools#4336 for more info) Closes pypa#395
I think handling this in wheel is the way to go. If I am not mistaken we already use |
This makes the METADATA file from bdist_wheel and the PKG-INFO file from setuptools render the same way (see pypa/setuptools#4336 for more info). Closes #395.
@abravalheri I've handled it in wheel. I'm now curious, though, why doesn't setuptools vendor wheel as it does with the other packages it wants to use? |
I would say it is a work in progress 😅 It is slightly more complicated than usual because the integration happens at entry-point level. |
setuptools version
setuptools==69.5.1 wheel==0.43.0
Python version
3.12
OS
macOS/Linux
Description
Requirements are normalized differently in sdist PKG-INFO file and wheel METADATA file
Expected behavior
Metadata in sdist and wheel are same
How to Reproduce
Using build I get an sdist and wheel that are mostly identical (sans trailing newline) but the
Requires-Dist:
values are formatted differently.Output
After extraction, the wheel metadata looks like this
The sdist metadata looks like this
Although the meaning is the same, it would be nice if metadata files in wheel and sdist were byte-for-byte identical.
For the record, the sdist's content seems to be in agreement with the way packaging wants:
I'm not sure if the best place to address the issue is in setuptools directly or in pypa/wheel.
The text was updated successfully, but these errors were encountered: