Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve activator documentation #2488

Merged
merged 1 commit into from Feb 4, 2023

Conversation

adamchainz
Copy link
Contributor

I wanted to point to a reference for VIRTUAL_ENV_DISABLE_PROMPT. It seems the existing documentation section for it was lost in #1519. Whilst restoring it, I tried to wordsmith the surrounding area of documentation to make it flow a little easier - less bracketed phrases, more consistent terminology, and more explanation of the prompt modification.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • [n/a] ensured there are test(s) validating the fix
  • [n/a] added news fragment in docs/changelog folder
  • updated/extended the documentation

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the CI please.

@gaborbernat gaborbernat merged commit a98c3f5 into pypa:main Feb 4, 2023
@adamchainz adamchainz deleted the improve_activator_documentation branch February 4, 2023 10:57
@adamchainz
Copy link
Contributor Author

Thanks!

joelvaneenwyk pushed a commit to joelvaneenwyk/virtualenv that referenced this pull request Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants