Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nushell installation failures #2475

Merged
merged 3 commits into from Dec 29, 2022
Merged

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Dec 29, 2022

This changes the Nushell installation method to use https://github.com/marketplace/actions/install-development-tools which in turn uses cargo binstall to install Nushell binary directly from GitHub releases. Unlike the previous method which points at https://api.github.com/repos/nushell/nushell/releases/latest this one should point at the build artifacts directly and hopefully avoids the 403 problems.

Also makes the CI script simpler.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@kubouch
Copy link
Contributor Author

kubouch commented Dec 29, 2022

There is a failure on MacOS but it seems unrelated to the changes I made.

@kubouch
Copy link
Contributor Author

kubouch commented Dec 29, 2022

OK, I'm falling back to using choco and brew on Windows & Mac so this PR affects only the Linux tests.

@gaborbernat gaborbernat merged commit 95a57f2 into pypa:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants