Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty string as version for find_compatible_in_house #2430

Merged
merged 1 commit into from Oct 8, 2022

Conversation

schaap
Copy link
Contributor

@schaap schaap commented Oct 7, 2022

The empty string is used in several locations to indicate the newest version. Interpret it as such instead of rejecting it as invalid.

This resolves the problem as reported in issue #2429, allowing virtualenv to correctly fall back on retrieving the newest wheel for bundled package that needed to be downloaded when the output of pip did not contain the package's location. See the issue for more details.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

The empty string is used in several locations to indicate the newest
version. Interpret it as such instead of rejecting it as invalid.
@gaborbernat gaborbernat merged commit cdf4225 into pypa:main Oct 8, 2022
@schaap schaap deleted the fix-find-compatible-in-house branch October 8, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants