Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_csh when running with the original csh #2418

Merged
merged 2 commits into from Oct 25, 2022
Merged

Fix test_csh when running with the original csh #2418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab8abac
Fix test_csh when running with the original csh
kulikjak Sep 14, 2022
1ebbd4f
Add news entry
kulikjak Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/2418.bugfix.rst
View file
Open in desktop
@@ -0,0 +1 @@
Allow the test suite to pass even with the original C shell (rather than ``tcsh``) - by :user:`kulikjak`.
4 changes: 3 additions & 1 deletion tests/unit/activation/test_csh.py
View file
Open in desktop
Expand Up @@ -7,6 +7,8 @@ def __init__(self, session):
super().__init__(CShellActivator, session, "csh", "activate.csh", "csh")

def print_prompt(self):
return "echo 'source \"$VIRTUAL_ENV/bin/activate.csh\"; echo $prompt' | csh -i"
# Original csh doesn't print the last newline,
# breaking the test; hence the trailing echo.
return "echo 'source \"$VIRTUAL_ENV/bin/activate.csh\"; echo $prompt' | csh -i ; echo"

activation_tester(Csh)