New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for seed packages having dependencies #1923
Conversation
gaborbernat
commented
Aug 14, 2020
- bump setuptools/wheel
- no OS dependent dependencies allowed
Fedora people here 😱 cc @frenzymadness I'd be very very VERY happy if this didn't come trough and the problem would be solved differently (most likely by not having the dependency). I follow the discussion in pypa/wheel#346
|
Your best chance is to raise the issue within wheel project and link it here 🤔 It's @agronholm you have to convince of this. |
@hroncok What exact issue would you have with wheel having dependencies? |
In Fedora, we don't ship the wheels bundled with virtualenv, but instead we build our own wheels of setuptools, pip and wheel. This means we apply our (also security) patches to them, we ensure how the wheels were built etc. We don't have to do that, but we want to. For example, for some (very) old Python versions (currently 2.7 and 3.4), we stop trying na we ship the CPython upstream bundled wheels (shipped in At this point, we only need to worry about compatibility problems of 3 projects: setuptools and pip for ensurepip and additionally also wheel for virtualenv. With this change we would not only need to also build wheels of packaging, pyparsing and six, but we would also need to worry about their cross-Python-version compatibility and the "current list of deps" changing over time. Assuming the (recursive) list of deps won't grow over time, we could probably do it, but if this opens a door to even bigger depchain growth. At the end, we might end up shipping / building several small stacks of wheels. I am not saying it is not possible, but if we could avoid that situation, I would be much happier. |
The current plan is to separate the |
That would certainly make it possible, as long as the |
Wheel will drop support for Python < 3.5 in v1.0 but I don't know when that will come out. I could keep wheel dependency free at least until then, if that makes your life easier. |
|
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
- bump setuptools/wheel - no OS dependent dependencies allowed Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>