Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in tests #898

Merged
merged 1 commit into from May 15, 2022
Merged

Fix typos in tests #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_main.py
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ def test_exception_handling(monkeypatch, capsys):

captured = capsys.readouterr()

# Hard-coding control characters for red text; couldn't find a succint alternative.
# Hard-coding control characters for red text; couldn't find a succinct alternative.
# Removing trailing whitespace on wrapped lines; trying to test it was ugly.
level = "\x1b[31mERROR \x1b[0m"
assert [line.rstrip() for line in captured.out.splitlines()] == [
Expand Down Expand Up @@ -57,7 +57,7 @@ def test_http_exception_handling(monkeypatch, capsys):

captured = capsys.readouterr()

# Hard-coding control characters for red text; couldn't find a succint alternative.
# Hard-coding control characters for red text; couldn't find a succinct alternative.
# Removing trailing whitespace on wrapped lines; trying to test it was ugly.
level = "\x1b[31mERROR \x1b[0m"
assert [line.rstrip() for line in captured.out.splitlines()] == [
Expand Down
4 changes: 2 additions & 2 deletions tests/test_upload.py
View file
Open in desktop
Expand Up @@ -170,7 +170,7 @@ def test_success_with_pre_signed_distribution(upload_settings, stub_repository):
)
assert result is None

# The signature shoud be added via package.add_gpg_signature()
# The signature should be added via package.add_gpg_signature()
package = stub_repository.upload.calls[0].args[0]
assert package.gpg_signature == (
"twine-1.5.0-py2.py3-none-any.whl.asc",
Expand All @@ -194,7 +194,7 @@ def test_success_when_gpg_is_run(upload_settings, stub_repository, monkeypatch):
result = upload.upload(upload_settings, [helpers.WHEEL_FIXTURE])
assert result is None

# The signature shoud be added via package.sign()
# The signature should be added via package.sign()
package = stub_repository.upload.calls[0].args[0]
assert len(package.run_gpg.calls) == 1
assert helpers.WHEEL_FIXTURE in package.run_gpg.calls[0].args[1]
Expand Down