Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log keyring tracebacks #890

Merged
merged 19 commits into from May 30, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 17 additions & 0 deletions tests/test_auth.py
Expand Up @@ -227,3 +227,20 @@ def test_warns_for_empty_password(
assert auth.Resolver(config, auth.CredentialInput()).password == password

assert caplog.messages[0].startswith(warning)


def test_log_exception_on_keyring_failure(config, monkeypatch, caplog):
class FailKeyring:
@staticmethod
def get_credential(system, username):
import os

# Let's simulate the error that occurred
# in https://github.com/pypa/twine/issues/889
os.environ["HOME"]
bhrutledge marked this conversation as resolved.
Show resolved Hide resolved

monkeypatch.setattr(auth, "keyring", FailKeyring())

assert not auth.Resolver(config, auth.CredentialInput()).get_username_from_keyring()
bhrutledge marked this conversation as resolved.
Show resolved Hide resolved

assert "KeyError: 'HOME'" in caplog.text and caplog.messages[0] == "'HOME'"
4 changes: 2 additions & 2 deletions twine/auth.py
Expand Up @@ -63,7 +63,7 @@ def get_username_from_keyring(self) -> Optional[str]:
# To support keyring prior to 15.2
pass
except Exception as exc:
logger.warning(str(exc))
logger.exception(exc)
bhrutledge marked this conversation as resolved.
Show resolved Hide resolved
return None

def get_password_from_keyring(self) -> Optional[str]:
Expand All @@ -73,7 +73,7 @@ def get_password_from_keyring(self) -> Optional[str]:
logger.info("Querying keyring for password")
return cast(str, keyring.get_password(system, username))
except Exception as exc:
logger.warning(str(exc))
logger.exception(exc)
return None

def username_from_keyring_or_prompt(self) -> str:
Expand Down