Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "safe_name" attribute of PackageFile for backwards compatibility #745

Merged
merged 2 commits into from Mar 17, 2021
Merged

Fix the "safe_name" attribute of PackageFile for backwards compatibility #745

merged 2 commits into from Mar 17, 2021

Commits on Mar 16, 2021

  1. Fix the "safe_name" attribute of PackageFile for backwards compatibility 

    Commit 0bd26af introduced a regression
that was causing some namespace packages with dots in them fail to
upload to PyPI. The reason is because
`packaging.utils.canonicalize_name()` is not equivalent to
`pkg_resources.safe_name()` as the former transforms the "." into "-",
while the later only does it for non-alphanumeric/. characters.

Closes: pypa#743
    @pablogsal
    pablogsal committed Mar 16, 2021
    Copy the full SHA
    d89585c View commit details
    Browse the repository at this point in the history

  2. Update docstring of safe_name() 

    Co-authored-by: Brian Rutledge <brian@bhrutledge.com>
    @pablogsal @bhrutledge
    pablogsal and bhrutledge committed Mar 16, 2021
    Copy the full SHA
    421ae7c View commit details
    Browse the repository at this point in the history