Nexus repo fix #694
Merged
Nexus repo fix #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
approved these changes
Sep 16, 2020
bhrutledge
requested changes
Sep 17, 2020
Co-authored-by: Brian Rutledge <brian@bhrutledge.com>
|
@cyrilou242 Thanks for the changes. I don't think the failing tests are related to your work (see #684), but I think it's worth a little more investigation before merging. I've restarted the jobs on this PR and |
|
Tests are passing and Brian's feedback seems resolved so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Fix proposal for #693
I put the full html response from Nexus in the test, and tried to keep the number of new lines small (but somehow readable).
Not sure if it's the best way to write the test.