Improve error message for unsupported metadata (#755)

* Improve error message for unsupported metadata * Add changelog entry
pypa · May 29, 2021 · 7acd94e · 7acd94e
1 parent 6e6cf82
commit 7acd94e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/changelog/755.bugfix.rst b/changelog/755.bugfix.rst
@@ -0,0 +1 @@
+Improve error message for unsupported metadata.
diff --git a/tests/test_package.py b/tests/test_package.py
@@ -278,6 +278,7 @@ def EmptyDist(filename):
         package_file.PackageFile.from_filename(filename, comment=None)
 
     assert "Invalid distribution metadata" in err.value.args[0]
+    assert "1.0, 1.1, 1.2, 2.0, and 2.1" in err.value.args[0]
 
 
 def test_malformed_from_file(monkeypatch):

diff --git a/twine/package.py b/twine/package.py
@@ -105,8 +105,11 @@ def from_filename(cls, filename: str, comment: Optional[str]) -> "PackageFile":
         # give us back empty metadata. At the very least, we should have a name
         # and version
         if not (meta.name and meta.version):
+            supported_metadata = list(pkginfo.distribution.HEADER_ATTRS)
             raise exceptions.InvalidDistribution(
-                "Invalid distribution metadata. Try upgrading twine if possible."
+                "Invalid distribution metadata. "
+                "This version of twine supports Metadata-Version "
+                f"{', '.join(supported_metadata[:-1])}, and {supported_metadata[-1]}"
             )
 
         py_version: Optional[str]