712 Handle EOFErrror with malformed file (#714)

* Handle EOFError on package upload * Linting
pypa · Nov 12, 2020 · 668f4db · 668f4db
1 parent 099ae0e
commit 668f4db
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/tests/fixtures/malformed.tar.gz b/tests/fixtures/malformed.tar.gz
diff --git a/tests/test_package.py b/tests/test_package.py
@@ -254,3 +254,13 @@ def EmptyDist(filename):
         package_file.PackageFile.from_filename(filename, comment=None)
 
     assert "Invalid distribution metadata" in err.value.args[0]
+
+
+def test_malformed_from_file(monkeypatch):
+    """Raise an exception when malformed package file triggers EOFError."""
+    filename = "tests/fixtures/malformed.tar.gz"
+
+    with pytest.raises(exceptions.InvalidDistribution) as err:
+        package_file.PackageFile.from_filename(filename, comment=None)
+
+    assert "Invalid distribution file" in err.value.args[0]
diff --git a/twine/package.py b/twine/package.py
@@ -76,8 +76,14 @@ def from_filename(cls, filename: str, comment: Optional[str]) -> "PackageFile":
         # Extract the metadata from the package
         for ext, dtype in DIST_EXTENSIONS.items():
             if filename.endswith(ext):
-                meta = DIST_TYPES[dtype](filename)
-                break
+                try:
+                    meta = DIST_TYPES[dtype](filename)
+                except EOFError:
+                    raise exceptions.InvalidDistribution(
+                        "Invalid distribution file: '%s'" % os.path.basename(filename)
+                    )
+                else:
+                    break
         else:
             raise exceptions.InvalidDistribution(
                 "Unknown distribution format: '%s'" % os.path.basename(filename)