Skip to content

Commit

Permalink
Improve error message for unsupported metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
bhrutledge committed May 18, 2021
1 parent ce3e76d commit 5fc0e5a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions tests/test_package.py
Expand Up @@ -278,6 +278,7 @@ def EmptyDist(filename):
package_file.PackageFile.from_filename(filename, comment=None)

assert "Invalid distribution metadata" in err.value.args[0]
assert "1.0, 1.1, 1.2, 2.0, and 2.1" in err.value.args[0]


def test_malformed_from_file(monkeypatch):
Expand Down
5 changes: 4 additions & 1 deletion twine/package.py
Expand Up @@ -105,8 +105,11 @@ def from_filename(cls, filename: str, comment: Optional[str]) -> "PackageFile":
# give us back empty metadata. At the very least, we should have a name
# and version
if not (meta.name and meta.version):
supported_metadata = list(pkginfo.distribution.HEADER_ATTRS)
raise exceptions.InvalidDistribution(
"Invalid distribution metadata. Try upgrading twine if possible."
"Invalid distribution metadata. "
"This version of twine supports Metadata-Version "
f"{', '.join(supported_metadata[:-1])}, and {supported_metadata[-1]}"
)

py_version: Optional[str]
Expand Down

0 comments on commit 5fc0e5a

Please sign in to comment.