Apply ruff/flake8-implicit-str-concat rule ISC001 #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At first glance all occurences where intentionally line split and had gotten cobbled to a single line, i think multi line Strings are needed |
|
This is the result of applying black in #255, and Would you rather add |
|
I think real multi line Strings should be used |
|
I'll try to do that with |
|
what i meant was using tripple quote string, not disabling fmt |
DimitriPapadopoulos
force-pushed
the
ISC
branch
4 times, most recently
from
80ddcad
to
65e102b
Compare
testing/test_regressions.py
Outdated
| @@ -35,7 +35,8 @@ def test_pkginfo_noscmroot(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> N | |||
|
|
|||
| tmp_path.joinpath(".git").mkdir() | |||
| p.joinpath("setup.py").write_text( | |||
| "from setuptools import setup;" 'setup(use_scm_version={"root": ".."})', | |||
| '''from setuptools import setup; | |||
There was a problem hiding this comment.
Do we want to keep setup.py as an one-liner?
from setuptools import setup;setup(use_scm_version={"root": ".."})Or perhaps change as follows?
from setuptools import setup
setup(use_scm_version={"root": ".."})
DimitriPapadopoulos
force-pushed
the
ISC
branch
4 times, most recently
from
4b80b86
to
9ce7c1e
Compare
- Revert to multiline strings, as before pypa#255 / ac2fee8. - Guard the multiline strings from black (and now ruff) unfolding them back to a single line. https://docs.astral.sh/ruff/rules/single-line-implicit-string-concatenation/
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.astral.sh/ruff/rules/single-line-implicit-string-concatenation/