Fix setuptools url and curl wants --location to follow redirects #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also removes:
sys.meta_path = [importer for importer in sys.meta_path if
importer.__class__.__module__ != 'pkg_resources.extern']
from _unload_pkg_resources.
These lines were removed from the version at: https://bootstrap.pypa.io/ez_setup.py
I don't know why the code there and here differs.
|
Fixes 557, I think. |
|
Fixes #557, I think. |
|
That meta path manipulation unloads the old import hook when upgrading setuptools. Why did you remove it? It was necessary to fix #519. |
|
@agronholm I was just reflecting what was at https://bootstrap.pypa.io/ez_setup.py I'll put them back. |
|
@agronholm I restored your fix and the PR makes more sense now. |
|
Thanks @jaraco . Can you also merge: #560 to get the ez_setup.py changes on the bootstrap branch so they show up at: https://bootstrap.pypa.io/ez_setup.py ? |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also removes:
from _unload_pkg_resources.
These lines were removed from the version at: https://bootstrap.pypa.io/ez_setup.py
I don't know why the code there and here differs.