Merge and update variable and params annotations from typeshed #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
pkg_resources-variables-params-annotations
branch
4 times, most recently
from
e179ba7
to
c9c9332
Compare
Avasam
force-pushed
the
pkg_resources-variables-params-annotations
branch
from
c9c9332
to
b0e1a1e
Compare
Avasam
commented
Feb 29, 2024
Comment on lines
+133
to
+137
| _NestedStr = Union[str, Iterable[Union[str, Iterable["_NestedStr"]]]] | ||
| _InstallerType = Callable[["Requirement"], Optional["Distribution"]] | ||
| _PkgReqType = Union[str, "Requirement"] | ||
| _EPDistType = Union["Distribution", _PkgReqType] | ||
| _MetadataType = Optional["IResourceProvider"] |
There was a problem hiding this comment.
These aliases come from the typeshed stub. Please lmk if you'd prefer different names or to make them public.
jaraco
approved these changes
Mar 3, 2024
…sources-variables-params-annotations
This was referenced Mar 6, 2024
…sources-variables-params-annotations
…sources-variables-params-annotations
2 tasks
Avasam
commented
Mar 6, 2024
| require = None | ||
| working_set = None | ||
| require = cast("Callable[..., Any]", None) | ||
| working_set = cast("WorkingSet", None) | ||
| add_activation_listener = None | ||
| cleanup_resources = None | ||
| resource_stream = None |
There was a problem hiding this comment.
I feel like the way it's been done in https://github.com/pypa/setuptools/pull/4242/files#diff-e3d3d454fa3a072c9f46f8affa27513892fbc2d245e87f57a5927a7be851de05R3332-R3349 is better than casting all these with forward references and redefining callable types.
Avasam
commented
Mar 7, 2024
pkg_resources/__init__.py
Outdated
Comment on lines
1742
to
1744
| egg_name: str | ||
| egg_info: str | ||
|
|
There was a problem hiding this comment.
Suggested change
| egg_name: str | |
| egg_info: str |
Actually there's no assurance that an egg is even found.
…github.com/Avasam/setuptools into pkg_resources-variables-params-annotations
…sources-variables-params-annotations
…sources-variables-params-annotations
Avasam
force-pushed
the
pkg_resources-variables-params-annotations
branch
from
fcca83f
to
93053ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Merge and update (because they were not all correct or exact) variable and params annotations from typeshed. Missing public annotations are missing from typeshed too.
This PR purposefully avoids adding TypeVars, overloads and return types. Those will all be tackled in a follow-up PR. Return types are inferred at this step.
Step 3.1 of #2345 (comment) but only for
pkg_resourcesPull Request Checklist
newsfragments/.(See documentation for details)