Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - normalize cwd path on dist path check (#4088) #4098

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

spxd
Copy link

@spxd spxd commented Oct 29, 2023

Summary of changes

Normalize CWD path for the comparing of distribute location.

Fixes #4088

Pull Request Checklist

@abravalheri
Copy link
Contributor

abravalheri commented Nov 20, 2023

@spxd thank you very much for the contribution.

The CI is currently complaining that the lines setuptools/command/easy_install.py 1253-1254,1259-1260 were changed but that the changes are not covered in tests (I understand that they probably were not covered before, but since this PR modifies them it would be important to add tests against regression).

Would it be possible to add a test for the update_pth function as well to cover those lines? (I believe that line 1288 can be ignored since it is setuptools-specific).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [easy_install] bug on checking the path of the distribution location
2 participants