GNU: use -Wl,-rpath,<dir> instead of -Wl,-R<dir> #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is supported in binutils for backwards compatibility, but in general `-R<path>` is equivalent to `--just-symbols=<path>` when `path` is a file; only when it's a directory, it's treated as `-rpath=<path>`. Better avoid that ambiguity and use `-rpath`. Also split `-Wl,--enable-new-dtags` and `-Wl,-rpath,...` into two separate arguments, which is more common, and more likely to be parsed correctly by compiler wrappers. This commit does not attempt to add `--enable-new-dtags` to other linkers than binutils ld/gold that support the flag.
|
Hi @haampie, thank you very much for the contribution!
If you want the code in that path to be changes, maybe it is better to discuss directly with the https://github.com/pypa/distutils maintainers and propose a PR there? Once the changes are added, pypa/distutils is pulled in the setuptools repo. |
|
Thanks, opened pypa/distutils#214 |
|
Looks like there is no activity in distutils though. |
|
We have to wait for the distutils maintainers to have the time to look into it, I don't think there is a way around that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4060
Summary of changes
Use
-rpathinstead of-Rwhen using binutils.The latter is supported in binutils for backwards compatibility, but in
general
-R<path>is equivalent to--just-symbols=<path>whenpathis a file; only when it's a directory, it's treated as
-rpath=<path>.Better avoid that ambiguity and use
-rpath.Also split
-Wl,--enable-new-dtagsand-Wl,-rpath,...into twoseparate arguments, which is more common, and more likely to be parsed
correctly by compiler wrappers.
This commit does not attempt to add
--enable-new-dtagsto otherlinkers than binutils ld/gold that support the flag.
Pull Request Checklist
newsfragments/].