Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inadvertent splatting of the name attribute #3547

Merged
merged 6 commits into from Aug 24, 2022
Merged

Remove inadvertent splatting of the name attribute #3547

merged 6 commits into from Aug 24, 2022

Commits on Aug 19, 2022

  1. Replicate problems with setup.py --version and auto-discovery

    @abravalheri
    abravalheri committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    9e4a1af View commit details
    Browse the repository at this point in the history

  2. Remove inadvertent splatting of the name attribute 

    The `name` attribute of a `Distribution` object is used by the
command-line processing system and is not intended to hold the
name of the distribution itself. Setting it to the name will
cause the command-line processing system to have a bad time.
    @jeamland @abravalheri
    jeamland authored and abravalheri committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    fd6e077 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry.

    @jeamland @abravalheri
    jeamland authored and abravalheri committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    e1fd1b4 View commit details
    Browse the repository at this point in the history

  4. Replicate problems with name discovery and dynamic versions 

    According to issue 3545 it seems that "name-discovery" happens, even
when the project already explicitly sets it.

This is related to parsing of dynamic versions (via `attr` directive),
which triggers the auto-discovery to obtain the value of `package_dir`.

The value of `package_dir` is used to find the path to the module
in `version = {"attr" = "module_name.attr_name"}`.
    @abravalheri
    abravalheri committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    ce572df View commit details
    Browse the repository at this point in the history

  5. Fix problems with name discovery and dynamic versions

    @abravalheri
    abravalheri committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    ffd88b0 View commit details
    Browse the repository at this point in the history

  6. Fix rst syntax in news fragment

    @abravalheri
    abravalheri committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    9a4b45f View commit details
    Browse the repository at this point in the history