New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PEP 660 allowing both "strict" and "lax/loose" approaches #3265
Merged
abravalheri
merged 55 commits into
pypa:feature/pep660
from
abravalheri:editable-link-tree
Jun 15, 2022
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
be3778e
include pep660 proof of concept
dholth 2bddfdf
include pep660 proof of concept (#3082)
abravalheri c6106b7
Add dist_info_dir param to dist_info command
abravalheri ad803ae
Change dist_info to better control output directory
abravalheri e36951e
Merge branch 'upstream/main' into build-editable-aggregate
abravalheri e55e51d
Change build_meta to use --output-dir instead of --egg-base for dist-…
abravalheri 1afb6c0
Make sure output_dir exists with dist_info
abravalheri 0e6870b
Avoid creating dist_info_dir before the command runs
abravalheri da6dd05
Fix signature for build_editable according to PEP 660
abravalheri e7123c6
Fix flake8 errors with build_meta
abravalheri 821d664
Add prepare_metadata_for_build_editable hook
abravalheri c642529
Editable rework dist_info to use --output-dir instead of --egg-base
abravalheri 5bb97d0
Remove unecessary editable dependency
abravalheri 3e9f441
Make sure setuptools itself can be installed with editable_wheel
abravalheri 5866b85
Rely on wheel and bdist_wheel for editable_wheel
abravalheri aee3245
Re-use dist-info dir for build_editable
abravalheri 33f2431
Always run editable install test
abravalheri 06fbc36
Start adding APIs for handling multiple editable modes
abravalheri 0bf1d4c
Rework PEP 660 PoC to re-use bdist_wheel
abravalheri 7b402eb
Temporarily support deprecated namespace packages
abravalheri a31df2e
Remove unused function
abravalheri 7ae5a69
Reorganise editable_wheel to allow different strategies
abravalheri a13adc8
Handle namespace_packages in editable_wheel
abravalheri 14eb855
Rename variable for clarity
abravalheri 8cb1344
Add namespace test
abravalheri f997500
Add initial implementation of editable strategy based on .pth file
abravalheri 73c65b2
Move test from test_develop to test_editable_install
abravalheri 59a39d9
Add test for PEP 420 packages
abravalheri a27b96b
Add tests for editable install focusing on namespaces
abravalheri 1a531db
Add template for MetaPathFinder that can be used in editable mode
abravalheri dd9886c
Add test for namespaces created via package_dir
abravalheri f210f16
Relax file types in discovery
abravalheri 994ca21
Add editable strategy with MetaPathFinder for top-level packages
abravalheri fba8717
Make sure top-level modules can be imported in editable install
abravalheri 3ba7ec4
Add logging messages to editable install
abravalheri 01ceef6
Fix error with Python 3.7
abravalheri 55260a7
Prevent errors when __path__ is not set
abravalheri 730b6e7
Prevent errors due to caching in sys.modules
abravalheri 50afbf4
Add LinkTree strategy for build executable
abravalheri 40f2f0f
Improve clarity of 'editable_wheel' code
abravalheri f5643f5
Initial editable MetaPathFinder for top-level pkgs
abravalheri 4112379
Add more tests for editable install
abravalheri 008a718
Add temporary workaround for packages.find.exclude
abravalheri f3786f3
Allow egg-info directory to be ignored in manifest
abravalheri 06d52fe
Fix problems with link assertions on Windows
abravalheri 9dc2588
Ignore transient warning
abravalheri 92c90db
Add a better workaround for 3260 in tests for editable tree
abravalheri a4e16fe
Remove unnecessary fixture from tests
abravalheri 99cf706
Test dynamic namespace path computation
abravalheri 3c71c87
Correctly handle namespace spec via PathEntryFinder
abravalheri d9c4a41
Add editable strategy based on a link tree
abravalheri 2ca60ad
Adequate tests to new internal API
abravalheri 501aec9
Add missing methods to PathEntryFinder
abravalheri 4687243
Avoid adding PathEntryFinder if not necessary
abravalheri daaf3ab
Ensure namespaces from ImportFinder handle additions to path
abravalheri File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abravalheri You forgot to add
'prepare_metadata_for_build_editable'
to the__all__
list.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @dalcinl. I am addressing this on #3477.