Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable xdist in PyPy #3121

Closed
wants to merge 2 commits into from

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Feb 18, 2022

Currently the test suite is problematic on PyPy.
As advised by @blink1073 in #3112 (comment) disabling xdist may help.

I put this experiment together to see how disabling xdist would affect the total testing time.

Summary of changes

  • Define pytest-xdist as a conditional dependency on setup.cfg, that is not installed in PyPy

Closes

Pull Request Checklist

Currently the test suite is problematic on PyPy.
There is some advice about disabling `xdist` in
pypa#3112 (comment)
to try helping with this issue.

This is just an experiment to see how disabling `xdist` would affect the
total testing time.
@abravalheri abravalheri changed the title [Experiment] Disable xdist in PyPy [CI] Disable xdist in PyPy Feb 18, 2022
@abravalheri
Copy link
Contributor Author

It turns out the test suite takes around 20 min to run for PyPy on Windows and Mac without xdist.

With xdist, PyPy on Windows seems to take around 15 min and PyPy on Mac seems to take 10 min.

There is some difference but maybe it is worth to avoid problems?

@blink1073
Copy link
Contributor

I'd say it is worth it if it is less flaky, but on my fork it had still failed without xdist, so I'm skeptical.

@abravalheri
Copy link
Contributor Author

abravalheri commented Feb 18, 2022

😩

Well, if it is still failing, then there is no much point on doing it. I will wait until the CI runs, but I will probably close the PR then.

Thank you very much @blink1073 for the help!

@abravalheri
Copy link
Contributor Author

Yeap, even after disabling xdist the tests are still failing.

Hopefully #3120 will be enough.

@abravalheri abravalheri deleted the experiment/no-xdist-pypy branch February 18, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants