Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor read_pkg_file #2635

Merged
merged 2 commits into from Apr 14, 2021
Merged

Refactor read_pkg_file #2635

merged 2 commits into from Apr 14, 2021

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Apr 10, 2021

Summary of changes

Refactor read_pkg_file from setuptools/dist.py in preparation for #2628, see #2628 (comment)
Additionally added rfc822_unescape function to reverse escaping which is applied to the Description field.
https://packaging.python.org/specifications/core-metadata/#description

/CC: @webknjaz

Pull Request Checklist

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdce8p I like what you've done here. It probably deserves a misc changelog fragment too.

(FYI I don't have a merge privilege on this repo so waiting for @jaraco to accept this patch)

@cdce8p
Copy link
Contributor Author

cdce8p commented Apr 12, 2021

@webknjaz I didn't add a changelog entry, since this change shouldn't effect the end user. If you would like that I do it anyway, please let me know.

@webknjaz
Copy link
Member

@cdce8p yep, that makes sense to me. I'll leave it to @jaraco to decide, then.

@jaraco
Copy link
Member

jaraco commented Apr 14, 2021

Looks good to me.

@jaraco jaraco merged commit 07eda18 into pypa:main Apr 14, 2021
@cdce8p cdce8p deleted the refactor-dist branch April 14, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants