Implement find_spec in vendored module importers
#2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
added a commit
to webknjaz/setuptools
that referenced
this pull request
Apr 8, 2021
webknjaz
added a commit
to webknjaz/setuptools
that referenced
this pull request
Apr 8, 2021
webknjaz
force-pushed
the
bugfixes/2632-importlib-find_spec
branch
from
c6c7b15
to
dcb418f
Compare
jaraco
reviewed
Apr 8, 2021
jaraco
reviewed
Apr 8, 2021
setuptools/extern/__init__.py
Outdated
| @@ -60,6 +62,13 @@ def create_module(self, spec): | |||
| def exec_module(self, module): | |||
| pass | |||
|
|
|||
| def find_spec(self, fullname, path=None, target=None): | |||
| """Produce a registered namespace matching module spec.""" | |||
There was a problem hiding this comment.
Suggested change
| """Produce a registered namespace matching module spec.""" | |
| """Return a module spec for vendored names.""" |
There was a problem hiding this comment.
By the way, I wanted to ask if there's any particular reason for having two duplicate loaders (one in pkg_resources and another one in setuptools) — can't one import another instead of maintaining the duplicates?
There was a problem hiding this comment.
I split them in preparation for separating pkg_resources into its own package, but never succeeded at that. It would be fine for setuptools to use the loader from pkg_resources again (but not vice-versa).
jaraco
approved these changes
Apr 8, 2021
This change makes the import warning emitted by Python 3.10 disappear but implementing the hook that is supposed to replace the old import mechanism. Refs: * https://bugs.python.org/issue42134 * https://bugs.python.org/issue43540 * pypa#2632 (comment) Fixes pypa#2632 Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
webknjaz
force-pushed
the
bugfixes/2632-importlib-find_spec
branch
from
e8e9a6d
to
dd1453b
Compare
webknjaz
commented
Apr 8, 2021
pkg_resources/extern/__init__.py
Outdated
| def find_spec(self, fullname, path=None, target=None): | ||
| """Return a module spec for vendored names.""" | ||
| return ( | ||
| importlib.machinery.ModuleSpec(fullname, self) |
There was a problem hiding this comment.
It looks like this could (should?) be https://docs.python.org/3/library/importlib.html#importlib.util.spec_from_loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This change makes the import warning emitted by Python 3.10 disappear
but implementing the hook that is supposed to replace the old import
mechanism.
Refs:
Fixes #2632
Pull Request Checklist
changelog.d/.(See documentation for details)