Fix .egg-info metadata support for zipimport #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests do not run on pytest 6; that one-line change to the version constraint seems necessary, although not directly related to this PR. I didn't see guidance on the order of commits, e.g. whether CI needs to pass on every rev, or you'd rather see a failing test then the fix. Let me know any changes you'd like to see. |
cooperlees
reviewed
Dec 16, 2020
webknjaz
reviewed
Jan 2, 2021
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
reviewed
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Previously pkg_resources behavior differed between regular path items and zipimport:
Extracting an sdist in most cases works for pkg_resources; the change lets you also repack the zip removing the top-level dir (or build with buck/bazel).
Closes #2489
Pull Request Checklist
changelog.d/.(See documentation for details)