Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Attempt to capture yet another common PyPy error #3120

Merged
merged 2 commits into from Feb 19, 2022

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Feb 18, 2022

In previous PRs, I have tried to improve the situation with tests being flaky on PyPy (specially via timeouts).

Still, there seems to be problems with ProcessPoolExecutor:

This might be related to the fact that pytest-xdist can struggle to run tests that use threads/processes themselves and that can be worse in PyPy. One alternative could be disabling xdist for PyPy (but I don't know how much longer the tests would take)

Summary of changes

  • Intercept futures.process.BrokenProcessPool/MemoryError on PyPy and xfail

Closes

Pull Request Checklist

@abravalheri
Copy link
Contributor Author

@abravalheri
Copy link
Contributor Author

At least this approach seems to have worked in this very own PR: https://github.com/pypa/setuptools/runs/5251092910?check_suite_focus=true#step:5:55

@abravalheri abravalheri marked this pull request as ready for review February 18, 2022 18:01
@abravalheri abravalheri mentioned this pull request Feb 18, 2022
2 tasks
@abravalheri abravalheri merged commit 3af7ff0 into pypa:main Feb 19, 2022
@abravalheri abravalheri deleted the work-on-pypy-errors branch February 19, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant